[6.2][CSApply] Don't attempt to mark autoclosures as non-implicit #81453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While building an initializer call the declaration reference should have the same implicitness as the call when it doesn't require thunking, otherwise don't attempt to mark autoclosures as non-implicit because it could break assumptions elsewhere. (cherry picked from commit 37e2f37)
hborla
approved these changes
May 12, 2025
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #81422
Explanation:
While building an initializer call the declaration reference should have the same implicitness as the call when it doesn't require thunking, otherwise don't attempt to mark autoclosures as non-implicit because it could break assumptions elsewhere.
Main Branch PR: [CSApply] Don't attempt to mark autoclosures as non-implicit #81422
Risk: Low (This is a narrow fix which could only be currently found by migration code).
Reviewed By: @AnthonyLatsis
Resolves: rdar://151157725
Testing: Added new tests to the test suite.
(cherry picked from commit 37e2f37)