Sema: Skip diagnosing witness availability for unavailable conformances #79537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a conformance is unavailable then checking for the potential unavailability of a witness doesn't make sense so skip it. This is necessary now because availability scopes no longer constrain the platform introduction version for a source range in that is annotated in source to be simultaneously unavailable and also introduced in a later version. This fixes a regression caused by swiftlang#79249. Resolves rdar://145255592.
tshortli
force-pushed
the
potentially-unavailable-witness-in-unavailable-conformance
branch
from
cc8b71c to
54e6900
Compare
Contributor
Author
|
@swift-ci please test |
tshortli
deleted the
potentially-unavailable-witness-in-unavailable-conformance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a conformance is unavailable then checking for the potential unavailability of a witness doesn't make sense so skip it. This is necessary now because availability scopes no longer constrain the platform introduction version for a source range in that is annotated in source to be simultaneously unavailable and also introduced in a later version.
This fixes a regression caused by #79249.
Resolves rdar://145255592.