AST: Begin consolidating availability constraint queries #79249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new query is designed to become the canonical source of information regarding whether a declaration is available to use in a given `AvailabilityContext`. It should be adopted as the foundational building block for all other queries that answer more specific questions about the availability of a specific delcaration. The implementation of this query has been copied from a variety of sources which should eventually be deleted once the new query has been fully adopted. NFC.
Call `swift::getAvailabilityConstraintsForDecl()` to gather the constraints that should be added to an AvailabilityContext when constraining it to the availability of a given declaration.
Contributor
Author
|
@swift-ci please test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Feb 21, 2025
If a conformance is unavailable then checking for the potential unavailability of a witness doesn't make sense so skip it. This is necessary now because availability scopes no longer constrain the platform introduction version for a source range in that is annotated in source to be simultaneously unavailable and also introduced in a later version. This fixes a regression caused by swiftlang#79249. Resolves rdar://145255592.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing the unsatisfied availability constraints for a declaration when used in a given context is a fundamental building block of availability checking, but the implementation is a bit scattered and hard to share everywhere it's needed. Begin consolidating that logic in
swift::getAvailabilityConstraintsForDecl()and adopt it when constraining anAvailabilityContextwith the attributes of a declaration.