Enable swift-corelibs-foundation tests on Windows #75932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift-corelibs-foundation#5074 @swift-ci please smoke test |
compnerd
approved these changes
Aug 20, 2024
Comment on lines
+1677
to
+1682
| $env:DISPATCH_INCLUDE_PATH="$($Arch.SDKInstallRoot)/usr/lib/swift" | ||
| $env:LIBXML_LIBRARY_PATH="$LibraryRoot/libxml2-2.11.5/usr/lib/$Platform/$ShortArch" | ||
| $env:LIBXML_INCLUDE_PATH="$LibraryRoot/libxml2-2.11.5/usr/include/libxml2" | ||
| $env:ZLIB_LIBRARY_PATH="$LibraryRoot/zlib-1.3.1/usr/lib/$Platform/$ShortArch" | ||
| $env:CURL_LIBRARY_PATH="$LibraryRoot/curl-8.9.1/usr/lib/$Platform/$ShortArch" | ||
| $env:CURL_INCLUDE_PATH="$LibraryRoot/curl-8.9.1/usr/include" |
There was a problem hiding this comment.
Is there a reason to prefer the environment variables over -Xcc -I... -Xlinker -L.. flags?
There was a problem hiding this comment.
I just found that was easier to manage when building locally, that way I could set up my environment and then just keep running swift test as I iterate rather than having to spell out the full invocation each time / remember what the right flags are. This also allows us to make sure that the right targets link the right things
andrurogerz
pushed a commit
to andrurogerz/swift
that referenced
this pull request
Sep 3, 2024
andrurogerz
pushed a commit
to andrurogerz/swift
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've gotten the SwiftPM build of swift-corelibs-foundation up and running on Windows, we can run its tests as part of the toolchain test suite. We need to pass some environment variables indicating where libxml2/zlib/curl have been built since those can't be declared as SwiftPM dependencies (similar to the dispatch path, except we also need to provide paths to the static libraries themselves since these are in build folders and not the install folder)