subpathsOfDirectory(atPath:) should throw on empty paths #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
approved these changes
Aug 16, 2024
Not in particular, although I think that may be best done as a followup since there are a lot of FileManager APIs that return |
This was referenced Aug 16, 2024
parkera
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully be the last of the Windows FileManager fixups for now 🙂
A swift-corelibs-foundation test revealed that
subpathsOfDirectory(atPath: "")throws on Darwin/Linux but returns an empty array on Windows. We should make it behave the same by throwing an error (however Windows currently throws.fileReadInvalidFileNamefor empty paths unlike Darwin/Linux which reports that the file doesn't exist, so we maintain that consistency with other APIs here)