[6.0] Add new _foundation_unicode and _FoundationCShims c modules to windows build script #74876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s build script (swiftlang#74796) * Add new _foundation_unicode and _FoundationCShims c modules to windows build script * Only copy directories that exist * Address feedback
|
@swift-ci please test |
stephentyrone
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #74796
Explanation: Updates the Windows build script to copy _foundation_unicode and _FoundationCShims (if they exist) like dispatch, os, and Block
Scope: Affects building toolchains on Windows
Original PR: #74796
Risk: Minimal - these directories do not yet exist so the change should be inert until we add the directories to the Foundation build
Testing: Testing done via swift-ci testing and toolchain builds
Reviewer: @compnerd