Add new _foundation_unicode and _FoundationCShims c modules to windows build script

[jmschonfeld]

Now that Foundation is producing new C modules (_foundation_unicode and _FoundationCShims) that clients depend upon because we do not enable library evolution for our modules, we need to ensure these modules are correctly installed into the just built SDK like the existing dispatch C modules.

[jmschonfeld]

swiftlang/swift-corelibs-foundation#4991
apple/swift-collections#395
swiftlang/swift-foundation#708

@swift-ci please build toolchain Windows platform

[jmschonfeld]

This corrected the issue in the windows toolchain build (the build above made it much farther than before)

[jmschonfeld]

@swift-ci please smoke test

[compnerd]

This also needs a change to the packaging manifest in https://github.com/apple/swift-installer-scripts.

[jmschonfeld]

This also needs a change to the packaging manifest in https://github.com/apple/swift-installer-scripts.

Yep I'll post a change to that repo that also includes updates for all of the new libraries being added

[compnerd]

Error: Error: swift.exe exited with code -1073741515.

-1073741515 = 0xc0000135, which I believe is DLL not found. I think that there are some path tweaks needed.

[jmschonfeld]

Error: Error: swift.exe exited with code -1073741515.

-1073741515 = 0xc0000135, which I believe is DLL not found. I think that there are some path tweaks needed.

Thanks! That's super helpful, there's likely still an issue to resolve here but this PR at least gets us a lot closer. Previously the toolchain build failed while building TSC since it couldn't find these modules but now it makes it all the way to the swift-inspect build before failing. I'll investigate what might be missing, perhaps we're not copying one of the new Foundation dll's over properly

[jmschonfeld]

@compnerd it looks like this change currently fails with the existing SCL-F because these _foundation_unicode / _FoundationCShims directories do not yet exist. Do you have a suggestion on how we could update the build script to only copy these if they exist so that we can stage this change in without requiring it to be landed in lockstep with the Foundation recore merge?

[compnerd]

Hmm, you could check if the directory exists via the Test-Path command in powershell.

[jmschonfeld]

@swift-ci please smoke test

[jmschonfeld]

@swift-ci please smoke test