[Windows] Prepare for swift-foundation in the toolchain

[jmschonfeld]

This PR is the same effective change as #74019 but for the Windows build via build.ps1

[jmschonfeld]

@swift-ci please test

[compnerd]

This seems relatively safe. I assume that the linkage here will be static and no DSOs (DLLs) need to be packaged up into the installer?

[compnerd]

@swift-ci please build toolchain Windows platform

[jmschonfeld]

This seems relatively safe. I assume that the linkage here will be static and no DSOs (DLLs) need to be packaged up into the installer?

This change itself is basically a no-op, Foundation doesn't use these settings yet. Eventually, the list of shared libraries we install into the toolchain will expand from Foundation/FoundationNetworking/FoundationXML to also include FoundationEssentials/FoundationInternationalization/_FoundationICU. Is there anything else we need to do to accommodate these extra shared libraries in the build script here?

[jmschonfeld]

Error: Cannot process argument transformation on parameter 'Project'. Cannot convert value "SwiftSyntax" to type "TargetComponent". Error: "Unable to match the identifier name SwiftSyntax to a valid enumerator name. Specify one of the following enumerator names and try again:
LLVM, Runtime, Dispatch, Foundation, XCTest"

@compnerd is there a better way I should be getting the SwiftSyntax directory from the early swift syntax build? I see other places in this file use Get-HostProjectCMakeModules Compilers but I'm not sure if that's available at this phase of the build process, should I be using that instead?

[compnerd]

I think that you need to build swift-syntax for the target - right now we only build swift-syntax for the host and there is no guarantee that the host and target are the same (we do support cross-compilation for the ARM64 distribution).

[jmschonfeld]

I think that you need to build swift-syntax for the target - right now we only build swift-syntax for the host and there is no guarantee that the host and target are the same (we do support cross-compilation for the ARM64 distribution).

I think that should be fine - we only need swift-syntax for our macro which only gets built for the host anyways, right?

[jmschonfeld]

Oh I see: Get-TargetProjectBinaryCache - we probably don't want the target one there got it ok yeah that should probably change

[jmschonfeld]

@swift-ci please build toolchain Windows platform

[jmschonfeld]

@swift-ci please smoke test

[jmschonfeld]

@compnerd it looks like the latest changes passed tests/toolchain builds - is this ok to go ahead and merge and cherry pick to release/6.0 to help unblock the swift-foundation work?

[compnerd]

I think that there is a small change that we should do to compnerd/swift-build to ensure that the other repositories are checked out with repo, but LGTM.

[jmschonfeld]

I think that there is a small change that we should do to compnerd/swift-build to ensure that the other repositories are checked out with repo, but LGTM.

Sounds good, LMK if there's anything I can help with on that front - looks like you have swift-foundation and swift-foundation-icu added there now which looks good. Once #73654 lands we'll likely need to bump swift-collections to the 1.1.1 revision there too since swift-foundation depends on swift-collections >=1.1.1