Skip to content

Update to swift-collections 1.1.1 on release/6.0, main, rebranch and next #73654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

lorentey
Copy link
Member

I skipped doing this in February, but toolchain builds should use the latest public package release.

@lorentey lorentey requested a review from shahmishal as a code owner May 15, 2024 23:09
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

@swift-ci build toolchain

@lorentey
Copy link
Member Author

Well, that's unfortunate:

CMake Error at Sources/OrderedCollections/CMakeLists.txt:10 (add_library):
  Cannot find source file:

    Utilities/_UnsafeBitSet.swift

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc


CMake Error at Sources/OrderedCollections/CMakeLists.txt:10 (add_library):
  No SOURCES given to target: OrderedCollections

@finagolfin
Copy link
Member

@etcwilde
Copy link
Contributor

The capitalization of Utilities/_UnsafeBitSet.swift is wrong in the CMakeLists file. The filename is _UnsafeBitset.swift with a lowercase s.

@lorentey
Copy link
Member Author

Yep; this is unfortunate as it will need to be corrected in a new swift-collections tag.

@lorentey
Copy link
Member Author

lorentey commented Jun 3, 2024

@swift-ci test

@lorentey
Copy link
Member Author

lorentey commented Jun 3, 2024

@swift-ci build toolchain

@lorentey lorentey marked this pull request as draft June 5, 2024 17:20
@lorentey
Copy link
Member Author

lorentey commented Jun 5, 2024

Reverted this to a draft PR to avoid accidentally landing a branch spec here. (We are waiting for swift-collections 1.1.1 to ship.)

@lorentey lorentey force-pushed the update-swift-collections branch from 750ea19 to d23fad9 Compare June 7, 2024 23:38
@lorentey lorentey marked this pull request as ready for review June 7, 2024 23:38
@lorentey
Copy link
Member Author

lorentey commented Jun 7, 2024

Swift Collections 1.1.1 is out; this is ready to land.

@lorentey lorentey changed the title Update to swift-collections 1.1 on main, rebranch and next Update to swift-collections 1.1.1 on main, rebranch and next Jun 11, 2024
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

@swift-ci build toolchain

@lorentey lorentey changed the title Update to swift-collections 1.1.1 on main, rebranch and next Update to swift-collections 1.1.1 on release/6.0 main, rebranch and next Jun 11, 2024
@lorentey lorentey changed the title Update to swift-collections 1.1.1 on release/6.0 main, rebranch and next Update to swift-collections 1.1.1 on release/6.0, main, rebranch and next Jun 11, 2024
@lorentey lorentey merged commit 89c3804 into swiftlang:main Jun 12, 2024
8 checks passed
@lorentey lorentey deleted the update-swift-collections branch June 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants