[6.0] [SymbolGraphGen] Handle cxx module imports in swift-symbolgraph-extract #74016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates swift-symbolgraph-extract to parse "-cxx-interoperability-mode" flags and update the underlying compiler invocation. This fixes a bug where were are unable to extract the symbol graph from swiftmodules with transitive cxx modules because we parsed cxx headers as c headers. rdar://128888548 (Add support for parsing cxx headers)
|
@swift-ci test |
bnbarham
approved these changes
May 30, 2024
bnbarham
added
🍒 release cherry pick
|
FYI I didn't review the original PR |
Oops sorry, I didn't pay enough attention to GitHub autocomplete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Updates swift-symbolgraph-extract to parse "-cxx-interoperability-mode" flags and updates the underlying compiler invocation. This fixes a bug where were are unable to extract the symbol graph from swiftmodules with transitive cxx modules because we parsed cxx headers as c headers.
Scope: Documentation generation
Issue: rdar://128888548 (Add support for parsing cxx headers)
Original PR: #73963
Risk: Very low, purely additive.
Testing: CI & at desk usage directly and via SwiftPM
Reviewer: @bnbarham @egorzhdan @daniel-grumberg