[SymbolGraphGen] Handle cxx module imports in swift-symbolgraph-extract #73963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain macOS platform |
|
We shouldn't duplicate any parsing or validation logic in See what The usage in Let's see what @QuietMisdreavus thinks. |
|
And thank you for contributing to the tool, @rauhul. |
rauhul
force-pushed
the
cxx-swift-symbolgraph-extract
branch
from
8d6cd2a to
84fe569
Compare
Updates swift-symbolgraph-extract to parse "-cxx-interoperability-mode" flags and update the underlying compiler invocation. This fixes a bug where were are unable to extract the symbol graph from swiftmodules with transitive cxx modules because we parsed cxx headers as c headers. rdar://128888548 (Add support for parsing cxx headers)
rauhul
force-pushed
the
cxx-swift-symbolgraph-extract
branch
from
84fe569 to
808ccd4
Compare
rauhul
changed the title
|
@swift-ci test |
|
@swift-ci smoke test |
rauhul
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 29, 2024
In order to extract symbol graphs for modules with transitive imports on cxx modules we need parse headers in cxx mode using the option: `-cxx-interoperability-mode=default`. This commit updates `swift-symbolgraph-extract` to pass the option when there is a Cxx module in the import graph. This option is a new addition to `swift-symbolgraph-extract` added in swiftlang/swift#73963. Prior to this option's introduction, extracting the symbol graph for cxx dependent modules would fail with an error similar to: "unknown type name 'namespace'". With this SwiftPM commit and `swift-symbolgraph-extract` _prior_ to 73963, users will instead see an argument parsing error like: "unknown option -cxx-interoperability-mode". With this change and `swift-symbolgraph-extract` 73963, the symbol graph is extracted properly.
rauhul
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 29, 2024
In order to extract symbol graphs for modules with transitive imports on cxx modules we need parse headers in cxx mode using the option: `-cxx-interoperability-mode=default`. This commit updates `swift-symbolgraph-extract` to pass the option when there is a Cxx module in the import graph. This option is a new addition to `swift-symbolgraph-extract` added in swiftlang/swift#73963. Prior to this option's introduction, extracting the symbol graph for cxx dependent modules would fail with an error similar to: "unknown type name 'namespace'". With this SwiftPM commit and `swift-symbolgraph-extract` _prior_ to 73963, users will instead see an argument parsing error like: "unknown option -cxx-interoperability-mode". With this change and `swift-symbolgraph-extract` 73963, the symbol graph is extracted properly.
egorzhdan
approved these changes
May 30, 2024
| @@ -319,6 +321,9 @@ namespace swift { | |||
| /// to the Swift language version. | |||
| version::Version cxxInteropCompatVersion; | |||
|
|
|||
| void setCxxInteropFromArgs(llvm::opt::ArgList &Args, | |||
There was a problem hiding this comment.
I think ideally this would go somewhere like ArgsToLangOptionsConverter (similarly to the existing ArgsToFrontendOptionsConverter), but I don't think that necessarily has to happen in this patch.
daniel-grumberg
approved these changes
May 30, 2024
rauhul
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 31, 2024
In order to extract symbol graphs for modules with transitive imports on cxx modules we need parse headers in cxx mode using the option: `-cxx-interoperability-mode=default`. This commit updates `swift-symbolgraph-extract` to pass the option when there is a Cxx module in the import graph. This option is a new addition to `swift-symbolgraph-extract` added in swiftlang/swift#73963. Prior to this option's introduction, extracting the symbol graph for cxx dependent modules would fail with an error similar to: "unknown type name 'namespace'". With this SwiftPM commit and `swift-symbolgraph-extract` _prior_ to 73963, users will instead see an argument parsing error like: "unknown option -cxx-interoperability-mode". With this change and `swift-symbolgraph-extract` 73963, the symbol graph is extracted properly.
rauhul
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 31, 2024
In order to extract symbol graphs for modules with transitive imports on cxx modules we need parse headers in cxx mode using the option: `-cxx-interoperability-mode=default`. This commit updates `swift-symbolgraph-extract` to pass the option when there is a Cxx module in the import graph. This option is a new addition to `swift-symbolgraph-extract` added in swiftlang/swift#73963. Prior to this option's introduction, extracting the symbol graph for cxx dependent modules would fail with an error similar to: "unknown type name 'namespace'". With this SwiftPM commit and `swift-symbolgraph-extract` _prior_ to 73963, users will instead see an argument parsing error like: "unknown option -cxx-interoperability-mode". With this change and `swift-symbolgraph-extract` 73963, the symbol graph is extracted properly.
rauhul
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 31, 2024
In order to extract symbol graphs for modules with transitive imports on cxx modules we need parse headers in cxx mode using the option: `-cxx-interoperability-mode=default`. This commit updates `swift-symbolgraph-extract` to pass the option when there is a Cxx module in the import graph. This option is a new addition to `swift-symbolgraph-extract` added in swiftlang/swift#73963. Prior to this option's introduction, extracting the symbol graph for cxx dependent modules would fail with an error similar to: "unknown type name 'namespace'". With this SwiftPM commit and `swift-symbolgraph-extract` _prior_ to 73963, users will instead see an argument parsing error like: "unknown option -cxx-interoperability-mode". With this change and `swift-symbolgraph-extract` 73963, the symbol graph is extracted properly.
rauhul
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 3, 2024
In order to extract symbol graphs for modules with transitive imports on C++ modules we need parse headers in C++ interop mode using the option: `-cxx-interoperability-mode=default`. This commit updates `swift-symbolgraph-extract` to pass the option when there is a C++ module in the import graph. This option is a new addition to `swift-symbolgraph-extract` added in swiftlang/swift#73963. Prior to this option's introduction, extracting the symbol graph for C++ dependent modules would fail with an error similar to: "unknown type name 'namespace'". With this SwiftPM commit and `swift-symbolgraph-extract` _prior_ to swiftlang/swift#73963, users will instead see an argument parsing error like: "unknown option -cxx-interoperability-mode". With this change and `swift-symbolgraph-extract` change in swiftlang/swift#73963, the symbol graph is extracted properly.
rauhul
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 12, 2024
In order to extract symbol graphs for modules with transitive imports on C++ modules we need parse headers in C++ interop mode using the option: `-cxx-interoperability-mode=default`. This commit updates `swift-symbolgraph-extract` to pass the option when there is a C++ module in the import graph. This option is a new addition to `swift-symbolgraph-extract` added in swiftlang/swift#73963. Prior to this option's introduction, extracting the symbol graph for C++ dependent modules would fail with an error similar to: "unknown type name 'namespace'". With this SwiftPM commit and `swift-symbolgraph-extract` _prior_ to swiftlang/swift#73963, users will instead see an argument parsing error like: "unknown option -cxx-interoperability-mode". With this change and `swift-symbolgraph-extract` change in swiftlang/swift#73963, the symbol graph is extracted properly.
rauhul
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 13, 2024
In order to extract symbol graphs for modules with transitive imports on C++ modules we need parse headers in C++ interop mode using the option: `-cxx-interoperability-mode=default`. This commit updates `swift-symbolgraph-extract` to pass the option when there is a C++ module in the import graph. This option is a new addition to `swift-symbolgraph-extract` added in swiftlang/swift#73963. Prior to this option's introduction, extracting the symbol graph for C++ dependent modules would fail with an error similar to: "unknown type name 'namespace'". With this SwiftPM commit and `swift-symbolgraph-extract` _prior_ to swiftlang/swift#73963, users will instead see an argument parsing error like: "unknown option -cxx-interoperability-mode". With this change and `swift-symbolgraph-extract` change in swiftlang/swift#73963, the symbol graph is extracted properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates swift-symbolgraph-extract to parse "-cxx-interoperability-mode"
flags and update the underlying compiler invocation. This fixes a bug
where were are unable to extract the symbol graph from swiftmodules with
transitive cxx modules because we parsed cxx headers as c headers.
rdar://128888548 (Add support for parsing cxx headers)