[6.0] Swift Caching Updates #72671
Merged
[6.0] Swift Caching Updates #72671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
akyrtzi
approved these changes
Mar 28, 2024
cachemeifyoucan
changed the title
Assign the path returned from dependency scanner for the module to the buffer identifier when loading modules from CAS. This fixes a warning in module trace file generation about invariant violation and also an assertion when generating swiftdeps file. rdar://122905379 (cherry picked from commit e99a93b)
Set context hash for source module so swift-driver can use the hash to compute output path if needed. rdar://119202702 (cherry picked from commit f71cce1)
Fix the wrong flag on windows version options. Those options are not paths. (cherry picked from commit 6af80e2)
When direct-cc1 scanning mode is enabled, do not inherit -Xcc options from the commandline as those are driver flags and clang importer already handle the conversion. rdar://125194535 (cherry picked from commit aad00e6)
cachemeifyoucan
force-pushed
the
eng/PR-swift-caching-6.0
branch
from
be10cc2 to
376d137
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
ping for 6.0 review and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Adding bug fixes for swift-caching build to swift/release/6.0 branch
Issue: Various bug fixes that impacts swift caching build
Original PR:
#72427
#72459
#72498
Risk: Low. Change to experimental swift caching feature.
Testing: UnitTests
Reviewer: @benlangmuir @artemcm