[Caching] Give swiftmodule loaded from CAS a path identifier #72427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
artemcm
approved these changes
Mar 19, 2024
Assign the path returned from dependency scanner for the module to the buffer identifier when loading modules from CAS. This fixes a warning in module trace file generation about invariant violation and also an assertion when generating swiftdeps file. rdar://122905379
There is no need to serialize module deps when caching is on because the entire build command has already capture the entire dependency tree. There is no need to encode the has for all dependencies and try to validate them. rdar://122914546
cachemeifyoucan
force-pushed
the
eng/PR-122905379
branch
from
d2daf72 to
782a421
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign the path returned from dependency scanner for the module to the buffer identifier when loading modules from CAS. This fixes a warning in module trace file generation about invariant violation and also an assertion when generating swiftdeps file.
rdar://122905379