Disable tracing in xpcproxy #72591
Merged
Disable tracing in xpcproxy #72591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add xpcproxy to the list of processes that handle tracing requests and therefore cannot themselves use tracing without deadlocking. rdar://124996590
|
@swift-ci Please test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
tshortli
reviewed
Mar 27, 2024
| @@ -33,7 +33,8 @@ static inline bool shouldEnableTracing() { | |||
| return false; | |||
| if (__progname && (strcmp(__progname, "logd") == 0 || | |||
| strcmp(__progname, "diagnosticd") == 0 || | |||
| strcmp(__progname, "notifyd") == 0)) | |||
| strcmp(__progname, "notifyd") == 0) || | |||
There was a problem hiding this comment.
There's a mistake here in the parenthesis placement - I'm fixing it in #72612.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add xpcproxy to the list of processes that handle tracing requests and therefore cannot themselves use tracing without deadlocking.
rdar://124996590