[CMake] Ensure module tracing is off during configuration #72405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such module usages are not relevant for the final build, they are used only to detect the capabilities of the compiler. This generalizes swiftlang#68453, and would be needed for Apple internal configurations that set `SWIFT_LOADED_MODULE_TRACE_FILE` when building the compiler. Addresses rdar://124954349
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
@swift-ci please test WebAssembly |
compnerd
approved these changes
Mar 18, 2024
etcwilde
approved these changes
Mar 18, 2024
|
@swift-ci please test Linux |
edymtt
deleted the
emiotto/no-module-trace-file-during-cmake-swift-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such module usages are not relevant for the final build, they are used only to detect the capabilities of the compiler.
This generalizes #68453, and would be needed for Apple internal configurations that set
SWIFT_LOADED_MODULE_TRACE_FILEwhen building the compiler.Addresses rdar://124954349