[CMake] Enable package CMO if possible #2736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
commented
Jul 17, 2024
| @@ -77,8 +77,28 @@ function(add_swift_syntax_library name) | |||
| -emit-module-path;${module_file}; | |||
| -emit-module-source-info-path;${module_sourceinfo_file}; | |||
| -emit-module-interface-path;${module_interface_file}; | |||
| -emit-private-module-interface-path;${module_private_interface_file} | |||
| -emit-private-module-interface-path;${module_private_interface_file}; | |||
| -no-verify-emitted-module-interface | |||
There was a problem hiding this comment.
Without this, the driver invokes -frontend -typecheck-module-from-interface job and that emits confusing warnings:
<unknown>:0: warning: ignoring -experimental-allow-non-resilient-access (overriden by -compile-module-from-interface or -typecheck-module-from-interface)
<unknown>:0: warning: ignoring -experimental-package-cmo (requires -experimental-allow-non-resilient-access)
There was a problem hiding this comment.
If they are just warnings, is it necessary to opt out of interface verification? We should just fix the diagnostics and I don't want you to get stuck with a configuration where the module interface is not verified (new problems with generated interface could escape as a result).
There was a problem hiding this comment.
OK, it's not really necessary to disable.
rintaro
force-pushed
the
cmake-package-cmo
branch
from
b5cd7c9 to
bbaa838
Compare
Package cross-module-optimization allows non-resilient access between modules as long as they share the same package name.
rintaro
force-pushed
the
cmake-package-cmo
branch
from
bbaa838 to
5a090ce
Compare
|
swiftlang/swift#75304 |
edymtt
reviewed
Jul 18, 2024
bnbarham
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package cross-module-optimization allows non-resilient access between modules as long as they share the same package name.