Skip to content

[SIL] Builtins that read or write memory may access pointers. #70773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nate-chandler merged 1 commit into from
Jan 9, 2024
Merged

[SIL] Builtins that read or write memory may access pointers. #70773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/SIL/Utils/MemAccessUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,10 @@ bool swift::isLetAddress(SILValue address) {
bool swift::mayAccessPointer(SILInstruction *instruction) {
if (!instruction->mayReadOrWriteMemory())
return false;
if (isa<BuiltinInst>(instruction)) {
// Consider all builtins that read/write memory to access pointers.
return true;
}
bool retval = false;
visitAccessedAddress(instruction, [&retval](Operand *operand) {
auto accessStorage = AccessStorage::compute(operand->get());
Expand Down
15 changes: 15 additions & 0 deletions test/SILOptimizer/deinit_barrier.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,18 @@ entry:
%retval = tuple ()
return %retval : $()
}

// CHECK-LABEL: begin running test {{.*}} on rdar120656227: is-deinit-barrier
// CHECK: builtin "int_memmove_RawPointer_RawPointer_Int64"
// CHECK: true
// CHECK-LABEL: end running test {{.*}} on rdar120656227: is-deinit-barrier
sil [ossa] @rdar120656227 : $@convention(thin) (Builtin.RawPointer, Builtin.RawPointer) -> () {
bb0(%42 : $Builtin.RawPointer, %9 : $Builtin.RawPointer):
%14 = integer_literal $Builtin.Int64, 27
%28 = integer_literal $Builtin.Int1, 1
specify_test "is-deinit-barrier @instruction"
%43 = builtin "int_memmove_RawPointer_RawPointer_Int64"(%42 : $Builtin.RawPointer, %9 : $Builtin.RawPointer, %14 : $Builtin.Int64, %28 : $Builtin.Int1) : $()
%68 = tuple ()
return %68 : $()
}