[SIL] Builtins that read or write memory may access pointers. #70773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an instruction `mayReadOrWriteMemory`, the `mayAccessPointer` predicate relies on the `visitAccessedAddress` utility to determine whether an instruction may access a pointer. That utility doesn't (and can't, without changing the representation of the builtin) visit `RawPointer` operands as used by memmove/memcpy builtins. Previously, this resulted `mayAccessPointer` returning `false` for such builtins. Here, this is fixed by making the predicate handle `BuiltinInsts` separately. Instead of just always returning `true` in the face of a builtin, rely on the BuiltinInfo associated with a BuiltinInst and use `mayReadOrWriteMemory`. rdar://120656227
Contributor
Author
|
@swift-ci please test |
meg-gupta
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an instruction
mayReadOrWriteMemory, themayAccessPointerpredicate relies on thevisitAccessedAddressutility to determine whether an instruction may access a pointer. That utility doesn't (and can't, without changing the representation of the builtin) visitRawPointeroperands as used by memmove/memcpy builtins.Previously, this resulted
mayAccessPointerreturningfalsefor such builtins. Here, this is fixed by making the predicate handleBuiltinInstsseparately. Instead of just always returningtruein the face of a builtin, rely on the BuiltinInfo associated with a BuiltinInst and usemayReadOrWriteMemory.rdar://120656227
Resolves #70813