[5.9][Sema/SILGen] Omnibus of init accessor feature improvements
#66715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Diagnose standalone `self` within init accessors - Diagnose references to members not listed in `initializes` or `accesses` attributes within init accessors - Enforce that `@out` parameters are fully initialized before every terminator - Detect and don't synthesize memberwise initializer with intersecting init accessor calls - Diagnose situations when memberwise init cannot be synthesized due to use of not-yet-initialized properties - Allow initialization expressions when computed property has init accessor; - Synthesize default argument for init accessor property included in memberwise initializer. (cherry picked from commit 5613006) (cherry picked from commit 935142f) (cherry picked from commit 3c924be) (cherry picked from commit db024d9) (cherry picked from commit f6fd0bc) (cherry picked from commit ddcfe01) (cherry picked from commit 4f59538) (cherry picked from commit cffc3fd) (cherry picked from commit 6ca9728) (cherry picked from commit 34c8cf6) (cherry picked from commit 8b1c9c9) (cherry picked from commit d1554f2) (cherry picked from commit fc895b4) (cherry picked from commit f58d407)
xedin
changed the title
init accessor feature improvementsinit accessor feature improvements
|
swiftlang/swift-syntax#1803 |
hborla
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #66681, #66513
Explanation:
Multitude of improvements to
init accessorsfeature:selfwithin init accessorsinitializesoraccessesattributes within init accessors@outparameters are fully initialized before every terminatorScope: Declarations and expression that define or use init accessors feature
Main Branch PRs: [Sema/SILGen] InitAccessors: Synthesize default arguments for init accessor properties #66681, [Sema/SIL] Improve diagnostics related to init accessors #66513
Risk: Very Low
Reviewed By: @hborla
Testing: Added regression test-cases to the suite.