Skip to content

[Sema/SILGen] InitAccessors: Synthesize default arguments for init accessor properties #66681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2023
Merged

[Sema/SILGen] InitAccessors: Synthesize default arguments for init accessor properties #66681

merged 4 commits into from
Jun 16, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 15, 2023

  • Allow initialization expressions when computed property has init accessor;
  • Synthesize default argument for init accessor property included in memberwise initializer.

xedin added 4 commits June 15, 2023 11:38
@xedin
[Parse] InitAccessors: Parse initializer exprs associated with comput…
8b1c9c9 
…ed properties that have `init` accessor

Initialization expressions are not allowed on computed properties
but if a property has `init` accessor it should be allowed because
it could be used by a memberwise initializer.
@xedin
[AST] InitAccessors: Requestify a "has init accessor" check
d1554f2
@xedin
[Sema] Formalize a way to check whether storage is initializable
fc895b4 
Previously only stored properties could be initializable but with
introduction of init accessors computed properties gained an ability
to specify initialzer expression and participation in memberwise
initialization for structs.
@xedin
[Sema/SILGen] Consider init exprs associated with init accessor prope…
f58d407 
…rties for memberwise init
@xedin
Copy link
Contributor Author

xedin commented Jun 15, 2023

swiftlang/swift-syntax#1795
@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jun 15, 2023

swiftlang/swift-syntax#1795
@swift-ci please test Windows platform

@ahoppen ahoppen removed their request for review June 16, 2023 10:47
@xedin xedin merged commit 9d342f1 into swiftlang:main Jun 16, 2023
@xedin xedin mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @hborla