🍒[5.7][Distributed] onReturn ad-hoc req must not allow mutating witness #59165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First merge: #58683 |
ktoso
changed the title
|
@swift-ci please test |
ktoso
force-pushed
the
pick-adhoc-mutating-onreturn
branch
from
90c140c to
67b4616
Compare
|
@swift-ci please test |
DougGregor
approved these changes
May 31, 2022
|
Rebased |
ktoso
force-pushed
the
pick-adhoc-mutating-onreturn
branch
from
67b4616 to
863ee97
Compare
|
@swift-ci please test and merge |
|
@swift-ci please smoke test |
ktoso
force-pushed
the
pick-adhoc-mutating-onreturn
branch
from
1a160df to
a6941e6
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Some adhoc requirements were missing the requirement checking for
mutating. Without this fix errors appear in synthesized code, confusing developers about what they did wrong.Risk: Low.
Review by: @xedin
Testing: PR testing
Original PR: #59162
Radar: rdar://94127604
Issue: #59159