[Distributed] Missing diagnostic for onReturn ad-hoc req when it is mutating witness #59162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
xedin
reviewed
May 31, 2022
test/Distributed/distributed_actor_system_missing_adhoc_requirement_impls.swift
Outdated
Show resolved
Hide resolved
ktoso
force-pushed
the
wip-adhoc-mutating-onreturn
branch
from
f04c3c9 to
2b0b389
Compare
|
Also added the same checks to remoteCall as the same is true over there. |
ktoso
force-pushed
the
wip-adhoc-mutating-onreturn
branch
from
670d944 to
ec909e3
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-adhoc-mutating-onreturn
branch
from
04f469c to
402501d
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59159
Resolves rdar://94127604
Tho re-building swift locally still, so will first verify locally