Add an opt-in flag to enforce (printable) ASCII only string literals #41365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
lorentey,
mikeash,
jckarter,
al45tair and
Catfish-Man
|
@swift-ci please test |
al45tair
reviewed
Feb 14, 2022
kubamracek
force-pushed
the
ascii-only-string-literals
branch
from
eb2709b to
78f97fd
Compare
|
@swift-ci please test |
|
Would be nice to have tests for:
|
kubamracek
force-pushed
the
ascii-only-string-literals
branch
from
78f97fd to
d3b4f2e
Compare
|
@karwa Added. |
|
@swift-ci please test |
mikeash
approved these changes
Feb 15, 2022
|
@swift-ci please test macOS platform |
|
@kubamracek would it be a good idea to include the non-ASCII string in the error message? |
al45tair
approved these changes
Feb 17, 2022
|
I've had some detailed offline discussions about this with Joe, and I think there are aspects that I haven't considered, specifically that string literals in source code don't necessarily need to always be Swift.String types (because of ExpressibleByStringLiteral), but there's more aspects of the not-full-Unicode-supporting stdlib variant. I'm going to put this PR on ice for now, perhaps coming back to it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation is that this flag,
-string-literals-must-be-ascii-only, is to be used for the 'freestanding' stdlib which is compiling without Unicode data tables -- see #40573 and #41258 -- or for other use cases where full Unicode string support is not desired. In those cases, it's nice to have a compile time proof that there's no string literals used in the source code that would require these Unicode data tables and therefore would crash at runtime.