Skip to content

Add a build flag to disable building Unicode support #40573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2022
Merged

Add a build flag to disable building Unicode support #40573

merged 3 commits into from
Jan 7, 2022

Conversation

Catfish-Man
Copy link
Contributor

No description provided.

@Catfish-Man Catfish-Man requested a review from Azoy December 15, 2021 21:50
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke benchmark

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed before running benchmark.

Azoy
Azoy approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these changes look good to me!

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 38af3e719e2360a1a9a78518cb67bcfb266b98f8

@Catfish-Man
Copy link
Contributor Author

@swift-ci please clean test

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please clean test

@Catfish-Man
Copy link
Contributor Author

argh I screwed up what branch I was on and that didn't have the change I meant to push

Catfish-Man
Catfish-Man commented Dec 21, 2021
View reviewed changes
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 38af3e719e2360a1a9a78518cb67bcfb266b98f8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 38af3e719e2360a1a9a78518cb67bcfb266b98f8

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man Catfish-Man marked this pull request as ready for review December 22, 2021 04:01
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

2 similar comments
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

3 similar comments
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit bebe119 into swiftlang:main Jan 7, 2022
@kubamracek kubamracek mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azoy Azoy Azoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Catfish-Man @swift-ci @Azoy