Skip to content

[update-checkout] Update the cmake that we build on Linux on main to cmake 3.20.2 (latest). #37210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented May 2, 2021

I am not changing the minimum cmake requirements anywhere. I am just changing
this to get ahead of bumpings of minimum cmake requirements in various places.

…cmake 3.20.2 (latest).

I am not changing the minimum cmake requirements anywhere. I am just changing
this to get ahead of bumpings of minimum cmake requirements in various places.
@gottesmm gottesmm requested review from drexin and shahmishal May 2, 2021 03:17
@gottesmm
Copy link
Contributor Author

gottesmm commented May 2, 2021

@swift-ci test

Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@finagolfin
Copy link
Member

Is the plan to increase the minimum to 3.20 for the next 5.6/6.0 release? Because just by increasing this for trunk, you will likely see CMake config changes that don't work for older CMake get introduced, which will effectively push the minimum up for the next release.

My understanding is that older CMake versions are still supported because the system packages in Ubuntu are these old versions. I'm fine with making those people use a newer CMake, as I only use Linux distros that keep CMake current, but just pointing out that you will be increasing the minimum CMake version too with this change (well, to whatever the minimum of the CMake version used on the macOS/Windows CI and this is).

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an unreleased CMake, 3.20.2 had a regression that I did get fixed, but I believe that will be in 3.20.3

@gottesmm
Copy link
Contributor Author

gottesmm commented May 3, 2021

I am actually going to do a lower one, 3.19. something.

@gottesmm gottesmm closed this May 3, 2021
@gottesmm gottesmm deleted the pr-4287f8562c0640fcf8b3a9521a6e588a4ce4e18f branch May 3, 2021 22:46
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants