-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Revert "Merge pull request #37114 from apple/revert-36377-NewDriverDefault" #37122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
@swift-ci please test Windows platform |
Build failed |
With: swiftlang/swift-driver#619 |
@swift-ci please test |
@swift-ci please test Windows platform |
Build failed |
@swift-ci test macOS platform |
@swift-ci test |
Build failed |
@shahmishal looks like PR bots on Linux have cmake 3.16, not cmake 3.17. |
Actually, I am incorrect. That is the cmake that we are building now. I am going to update to a newer cmake using update-checkout. |
Once #37210 lands, we should be good to merge this. @shahmishal would be good to update the Linux bots as well so we don't build this. But I think for now I want to unblock this. |
WIth swiftlang/swift-driver#619 |
Build failed |
WIth swiftlang/swift-driver#619 |
This reverts commit 937e1a3, reversing
changes made to c2dc8e3.
A change originally merged in #36377 got reverted in: #37114
The reason for this is because SwiftDriver's CMake build behaves differently when using CMake Version <3.17 and some developers who were using an older CMake started hitting errors.
This PR reverts the revert, bringing back the new driver as the default installation.
Before it gets merged one of two things needs to happen: