Make Float16 unavailable on macOS and macCatalyst, as in Apple Swift #32868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
…Swift. LLVM doesn't have a stable ABI for Float16 on x86 yet; we're working with Intel to get that fixed, but we don't want to make the type available on macOS until a stable ABI is actually available, because we'd break binaries compiled before any calling convention changes if we do.
stephentyrone
force-pushed
the
float16-unavailable-on-mac
branch
from
50ae0c2 to
735a1e7
Compare
|
@swift-ci test |
kylemacomber
approved these changes
Jul 14, 2020
lorentey
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM doesn't have a stable ABI for Float16 on x86 yet; I've asked Intel to take a look at that, but we don't want to make the type available on macOS until a stable ABI is actually available, because we'd break binaries compiled before any calling convention changes if we do.
Note that the calling conventions are stable for Float16 on Apple Silicon. So the type should eventually be made available on macOS for Apple Silicon even if we never get stable calling conventions on x86, but it will simplify everything if we just mark the type unavailable in the short term on macOS.