ABIChecker: obsoleted/unavailable ABI-public decls #33694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci smoke test macOS |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
benrimmington
force-pushed
the
legacy-abi-checker
branch
from
46b0b70 to
dacb52d
Compare
|
@swift-ci Please smoke test |
|
I've added baseline commits from before and after the tool update, so that it's possible to review the changes. |
nkcsgexi
requested changes
Aug 31, 2020
benrimmington
force-pushed
the
legacy-abi-checker
branch
from
dacb52d to
93ee9a5
Compare
|
@swift-ci Please smoke test |
|
@nkcsgexi Are you still going to update the tool and baselines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the api-digester tool, to include obsoleted/unavailable declarations in the ABI baseline.
ABI/API baselines were updated (before and after) with:
cd build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/ bin/swift-api-digester \ -abi \ -avoid-location \ -dump-sdk \ -module Swift \ -module-cache-path /tmp/ModuleCache \ -o lib/swift/FrameworkABIBaseline/Swift/ABI/macos.json \ -sdk /tmp/dummy.sdk \ -v bin/swift-api-digester \ -avoid-location \ -dump-sdk \ -module Swift \ -module-cache-path /tmp/ModuleCache \ -o lib/swift/FrameworkABIBaseline/Swift/API/macos.json \ -sdk /tmp/dummy.sdk \ -vThen the attributes in LegacyABI.swift were updated. Previously, the tool would have falsely detected these newly-unavailable declarations as removed from the ABI.