Skip to content

[test] Reenable NSValueBridging tests on i386 CPUs #32781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

[test] Reenable NSValueBridging tests on i386 CPUs #32781

merged 1 commit into from
Jul 9, 2020

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Jul 9, 2020

Instead, disable the specific tests we cannot run with a targeted platform conditional.

This is a followup to #32515.

@lorentey
[test] Reenable NSValueBridging tests on i386
b42910a 
Instead, disable tests we cannot run with a targeted platform conditional.
@lorentey
Copy link
Member Author

lorentey commented Jul 9, 2020

@swift-ci test

@lorentey lorentey requested a review from gribozavr July 9, 2020 18:37
gribozavr
gribozavr approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@gribozavr gribozavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gribozavr gribozavr merged commit 5c3f34f into swiftlang:master Jul 9, 2020
@lorentey lorentey deleted the NValueBridging-adjustment branch July 9, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gribozavr gribozavr gribozavr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentey @gribozavr