-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[test] Reinstate CoreGraphics↔︎NSValue bridging tests on iOS/watchOS/tvOS #32515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Reinstate CoreGraphics↔︎NSValue bridging tests on iOS/watchOS/tvOS #32515
Conversation
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
cc: @compnerd |
Build failed |
Fascinating! 🤔
|
fbc949c
to
b3fb762
Compare
The iOS 10.3 simulator predates stable Swift ABI, so it doesn't have the UIKit overlay. Weak linking it fails, and since the executable isn't directly loading the UIKit framework, the method won't be available, either. The 32-bit simulator tests are deploying the just-built stdlib & in-tree overlays to 10.3, which is not really useful at this point -- only the Swift 5 compatibility runtime will ever get deployed to iOS 10.3 in production, so that's what we should be testing. |
@swift-ci test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -18,11 +18,18 @@ | |||
// | |||
// REQUIRES: objc_interop | |||
|
|||
// The UIKit overlay isn't present on iOS 10.3. | |||
// UNSUPPORTED: CPU=i386 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other tests that don't depend on UIKit? Could we put these tests into a separate file that does not run on the i386 iOS simulator, while the rest of the test does?
You could also use StdlibUnittest facilities to skip a test on the simulator. See these tests: https://github.com/apple/swift/blob/30ccb529485dac910a8f2a11504205fb5ea16873/validation-test/StdlibUnittest/Common.swift#L153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense -- I'll submit a followup PR soon.
This is a followup to #32502, reinstating a Foundation test.