[build-presets] Enable stdlib assertions on Linux installations #32511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable stdlib assertions in mixin_linux_installation. Other presets which use mixin_lightweight_assertions, such as buildbot_linux_crosscompile_android and buildbot_osx_package, are not affected by this change. Stdlib assertions are needed by reflection validation tests on Linux.
|
@swift-ci smoke test |
|
@shahmishal is the right person for this imo. |
shahmishal
approved these changes
Jun 23, 2020
|
@swift-ci smoke test |
|
Huh, two lldb tests are unexpectedly passing after this change. I'll take a look. |
|
These two are known UPASS after updating to newer Xcode. |
|
This PR disables it for now: swiftlang/llvm-project#1375 @swift-ci smoke test macOS |
|
@swift-ci smoke test macOS |
|
It looks like CI couldn't find the llvm-project PR: /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm-project failed (ret=128): ['git', 'fetch', 'origin', 'pull/1375/merge:ci_pr_1375', '--tags'] It got merged, so maybe that's why. I'll try again. |
|
@swift-ci smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable stdlib assertions in mixin_linux_installation.
Other presets which use mixin_lightweight_assertions, such as
buildbot_linux_crosscompile_android and buildbot_osx_package, are not
affected by this change.
Stdlib assertions are needed by reflection validation tests on Linux
(see #32339).
cc @augusto2112