[lldb] Re-enable test after Xcode upgrade #1378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test macos |
fredriss
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
This is fine for the branch, however it would be great to understand why it started working if we haven't yet? @adrian-prantl?
|
@shahmishal says they started passing after upgrading the Xcode on the bots. Based on @adrian-prantl description in #1381 it seems like it might depend on 212faae which is not on the 5.3 branch. So let's see what PR testing says. |
|
I thought that they were fixed by 212faae (which is not on this branch). But if the Xcode upgrade is really responsible then it must be a difference in debug info generated for the stdlib, or a change in the SDK. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.