Skip to content

[Refactoring] Fix a crasher in AddEquatableContext #32435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2020
Merged

[Refactoring] Fix a crasher in AddEquatableContext #32435

merged 1 commit into from
Jun 17, 2020

Conversation

theblixguy
Copy link
Collaborator

When computing available refactoring kinds, we should only create AddEquatableContext for an extension if it extends a nominal type.

Resolves SR-13000
Resolves rdar://problem/64316798

@theblixguy theblixguy requested a review from nathawes June 17, 2020 17:13
@theblixguy
Copy link
Collaborator Author

@swift-ci please smoke test

Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – thanks for the fix!

@theblixguy
Copy link
Collaborator Author

Windows failure is unrelated (failing test is Profiler/coverage_relative_path.swift, which should be fixed by #32434)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants