Skip to content

Fix coverage test on Windows #32434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2020
Merged

Fix coverage test on Windows #32434

merged 3 commits into from
Jun 17, 2020

Conversation

keith
Copy link
Member

@keith keith commented Jun 17, 2020

Relying on $PWD made this invalid on Windows

keith added 2 commits June 17, 2020 10:01
@keith
Fix coverage test on Windows
9e4f17b 
Relying on $PWD made this invalid on Windows
@keith
Use %t
48f9f2d
@theblixguy theblixguy requested a review from compnerd June 17, 2020 17:24
@compnerd
Copy link
Member

@swift-ci please test Windows platform

compnerd
compnerd approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to repair the build. Do you think that you could do a follow up change to use something other than foo, bar, baz (outer, middle, inner or something else a bit more meaningful would be great).

@compnerd compnerd mentioned this pull request Jun 17, 2020
Closed
@compnerd
Copy link
Member

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member

@swift-ci please smoke test Linux platform

@keith
Copy link
Member Author

keith commented Jun 17, 2020

Yea sure I can clean that up

@theblixguy theblixguy mentioned this pull request Jun 17, 2020
Merged
@compnerd compnerd merged commit f387ea3 into swiftlang:master Jun 17, 2020
@keith keith deleted the ks/fix-coverage-test-on-windows branch June 17, 2020 21:14
@keith keith mentioned this pull request Jun 17, 2020
Merged
@keith
Copy link
Member Author

keith commented Jun 17, 2020

Here's the follow up! #32443

@theblixguy theblixguy mentioned this pull request Jun 18, 2020
Merged
@varungandhi-apple varungandhi-apple mentioned this pull request Sep 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith @compnerd