[Shepherd] Support classes with missing designated inits #28629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
added 4 commits
January 6, 2020 10:15
Since this is going to be something modules tell clients, rather than something clients discover about modules, serialize it.
We’re going to start serializing this for public types that have non-public-or-@usableFromInline initializers, so turn it into a request that we can query and cache it in the existing bit.
Specially print @_hasMissingDesignatedInitializers and @_inheritsConvenienceInitializers in module interfaces Fixes rdar://51249311
…alizers Because we won’t be serializing this attribute, add custom diagnostics for the cases where: - We add @_hasMissingDesignatedInits to an open class, which means subclasses won’t be able to inherit its inits - We remove @_inheritsConvenienceInitializers, which means APIs are removed
CodaFi
force-pushed
the
convenience-never-comes-without-cost
branch
from
d9a008d to
4d73173
Compare
|
@swift-ci please smoke test |
|
Off to 5.2 with you. ⛵️ |
This was referenced Jan 6, 2020
|
@CodaFi I think that this has caused a regression on android: https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/3159/console |
|
Hm, that’s not a particularly illuminating failure log. Do you have access to an android environment to gather more information? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shepherds #26060