[ModuleInterface] Support classes with missing designated inits #26060

harlanhaskins · 2019-07-10T17:16:53Z

When a superclass in one module has a designated init that is non-public (or
@usableFromInline), and another class attempts to subclass that class from a
different module, we would have enough information in a binary module to
know that the class can't be subclassed because it's missing designated
initializers.

But if we're in a module interface, there's no indication that there was
an un-printed initializer. Introduce a new attribute
@_hasMissingDesignatedInits on classes that have non-public or usable
from inline designated initializers, and ensure that the bit is set when
we parse one.

Also, if a class inherits from something that has missing designated inits, but it overrides all designated initializers anyway, it should be allowed to inherit convenience inits even if they're missing from the interface. As such, add another attribute @_inheritsSuperclassInitializers, and promote the existing bit to an attribute. This'll ensure that we follow initializer inheritance the same way we would with bits in the serialized module.

Fixes rdar://51249311

jrose-apple

Can you add tests for the internal subclass case? I think we haven't completely solved the problem without saying "but this class does override all the designated initializers, even though you can't see them".

include/swift/AST/Decl.h

lib/AST/ASTPrinter.cpp

slavapestov · 2019-07-11T21:02:03Z

This should replace ClassDecl::inheritsSuperclassInitializers() and setInheritsSuperclassInitializers() too, together with the existing code for computing that in TypeChecker::addImplicitConstructors().

harlanhaskins · 2019-07-24T23:11:28Z

I'd really like, at some point, to pull out this logic from addImplicitConstructors, but it's really tightly woven with the logic for diagnosing missing overrides and creating implicit overrides.

harlanhaskins · 2019-07-24T23:14:18Z

@swift-ci please smoke test

include/swift/AST/Decl.h

lib/AST/ASTPrinter.cpp

include/swift/AST/Attr.def

test/ParseableInterface/inherits-superclass-initializers-client.swift

harlanhaskins · 2019-07-25T23:36:08Z

@swift-ci please test

harlanhaskins · 2019-07-26T00:08:41Z

@swift-ci please test

harlanhaskins · 2019-07-26T21:11:55Z

@swift-ci please test

harlanhaskins · 2019-07-27T06:19:49Z

@swift-ci please test

harlanhaskins · 2019-07-29T17:52:21Z

@swift-ci please test

include/swift/AST/Decl.h

harlanhaskins · 2019-11-20T01:06:01Z

@nkcsgexi Can you look at the api-digester changes here and tell me if they make sense?

harlanhaskins · 2019-11-20T03:40:53Z

@swift-ci please test

harlanhaskins · 2019-11-20T20:04:54Z

@swift-ci please test

swift-ci · 2019-11-20T21:42:10Z

Build failed
Swift Test OS X Platform
Git Sha - 9a6bbdac1ba695c88f34170e52e5e6c027ff13b7

harlanhaskins · 2019-11-20T23:45:50Z

@swift-ci please test

swift-ci · 2019-11-21T00:33:28Z

Build failed
Swift Test Linux Platform
Git Sha - 9a6bbdac1ba695c88f34170e52e5e6c027ff13b7

harlanhaskins · 2019-11-21T00:38:29Z

@swift-ci please clean test Linux

swift-ci · 2019-11-21T03:31:52Z

Build failed
Swift Test Linux Platform
Git Sha - 9a6bbdac1ba695c88f34170e52e5e6c027ff13b7

harlanhaskins · 2019-11-21T17:55:57Z

@swift-ci please test

swift-ci · 2019-11-21T17:57:51Z

Build failed
Swift Test Linux Platform
Git Sha - 20c51258f9308573a65c061c904045ea511ae046

swift-ci · 2019-11-21T17:58:12Z

Build failed
Swift Test OS X Platform
Git Sha - 20c51258f9308573a65c061c904045ea511ae046

Since this is going to be something modules tell clients, rather than something clients discover about modules, serialize it.

We’re going to start serializing this for public types that have non-public-or-@usableFromInline initializers, so turn it into a request that we can query and cache it in the existing bit.

Specially print @_hasMissingDesignatedInitializers and @_inheritsConvenienceInitializers in module interfaces Fixes rdar://51249311

…alizers Because we won’t be serializing this attribute, add custom diagnostics for the cases where: - We add @_hasMissingDesignatedInits to an open class, which means subclasses won’t be able to inherit its inits - We remove @_inheritsConvenienceInitializers, which means APIs are removed

harlanhaskins · 2019-11-22T02:29:29Z

@swift-ci please test

swift-ci · 2019-11-22T02:29:49Z

Build failed
Swift Test Linux Platform
Git Sha - b9468463a3d7604e95abcc0ca5d769928f9eeb80

swift-ci · 2019-11-22T02:29:57Z

Build failed
Swift Test OS X Platform
Git Sha - b9468463a3d7604e95abcc0ca5d769928f9eeb80

CodaFi · 2020-01-06T20:49:10Z

Shepherded in #28629

harlanhaskins requested review from slavapestov and jrose-apple July 10, 2019 17:16

jrose-apple reviewed Jul 10, 2019

View reviewed changes

harlanhaskins force-pushed the an-inconvenient-init branch 4 times, most recently from 1c8ed5e to f76a1b4 Compare July 24, 2019 23:08

harlanhaskins requested a review from jrose-apple July 24, 2019 23:11

jrose-apple reviewed Jul 25, 2019

View reviewed changes

harlanhaskins force-pushed the an-inconvenient-init branch 2 times, most recently from ec45b56 to 1be55c1 Compare July 25, 2019 20:57

This comment has been minimized.

Sign in to view

harlanhaskins force-pushed the an-inconvenient-init branch from 1be55c1 to e59b95d Compare July 26, 2019 21:11

This comment has been minimized.

Sign in to view

harlanhaskins force-pushed the an-inconvenient-init branch from e59b95d to c3eeabb Compare July 27, 2019 06:19

This comment has been minimized.

Sign in to view

harlanhaskins force-pushed the an-inconvenient-init branch from c3eeabb to 6074884 Compare July 29, 2019 17:52

This comment has been minimized.

Sign in to view

slavapestov reviewed Nov 19, 2019

View reviewed changes

include/swift/AST/Decl.h Outdated Show resolved Hide resolved

include/swift/AST/Decl.h Outdated Show resolved Hide resolved

harlanhaskins force-pushed the an-inconvenient-init branch from b12a26c to 2af74a6 Compare November 20, 2019 00:57

harlanhaskins force-pushed the an-inconvenient-init branch from 2af74a6 to 9a6bbda Compare November 20, 2019 18:50

harlanhaskins force-pushed the an-inconvenient-init branch from 9a6bbda to 20c5125 Compare November 20, 2019 22:55

swiftlang deleted a comment from swift-ci Nov 20, 2019

harlanhaskins force-pushed the an-inconvenient-init branch from 20c5125 to b946846 Compare November 21, 2019 17:45

harlanhaskins mentioned this pull request Nov 21, 2019

[AST] Add attributes for hasMissingDesignatedInitializers and inheritsConvenienceInitializers #28425

Merged

Harlan Haskins added 4 commits November 21, 2019 17:28

[Serialization] Serialize hasMissingDesignatedInitializers

ff614e4

Since this is going to be something modules tell clients, rather than something clients discover about modules, serialize it.

[Sema] Requestify hasMissingDesignatedInitializers

7e998b1

We’re going to start serializing this for public types that have non-public-or-@usableFromInline initializers, so turn it into a request that we can query and cache it in the existing bit.

[ModuleInterface] Add printing for new attributes

c90306d

Specially print @_hasMissingDesignatedInitializers and @_inheritsConvenienceInitializers in module interfaces Fixes rdar://51249311

harlanhaskins force-pushed the an-inconvenient-init branch from b946846 to 06b6a78 Compare November 22, 2019 01:32

CodaFi mentioned this pull request Dec 7, 2019

[Shepherd] Support classes with missing designated inits #28629

Merged

CodaFi closed this Jan 6, 2020

belkadan mentioned this pull request Sep 11, 2019

[SR-11454] Adding a designated initializer can be source-breaking #53855

Open

[ModuleInterface] Support classes with missing designated inits #26060

[ModuleInterface] Support classes with missing designated inits #26060

Uh oh!

Conversation

harlanhaskins commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrose-apple left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

slavapestov commented Jul 11, 2019

Uh oh!

harlanhaskins commented Jul 24, 2019

Uh oh!

harlanhaskins commented Jul 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harlanhaskins commented Jul 25, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

harlanhaskins commented Jul 26, 2019

Uh oh!

This comment has been minimized.

harlanhaskins commented Jul 26, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

harlanhaskins commented Jul 27, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

harlanhaskins commented Jul 29, 2019

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

harlanhaskins commented Nov 20, 2019

Uh oh!

harlanhaskins commented Nov 20, 2019

Uh oh!

harlanhaskins commented Nov 20, 2019

Uh oh!

swift-ci commented Nov 20, 2019

Uh oh!

harlanhaskins commented Nov 20, 2019

Uh oh!

swift-ci commented Nov 21, 2019

Uh oh!

harlanhaskins commented Nov 21, 2019

Uh oh!

swift-ci commented Nov 21, 2019

Uh oh!

harlanhaskins commented Nov 21, 2019

Uh oh!

swift-ci commented Nov 21, 2019

Uh oh!

swift-ci commented Nov 21, 2019

Uh oh!

harlanhaskins commented Nov 22, 2019

Uh oh!

swift-ci commented Nov 22, 2019

Uh oh!

swift-ci commented Nov 22, 2019

Uh oh!

CodaFi commented Jan 6, 2020

Uh oh!

Uh oh!

harlanhaskins commented Jul 10, 2019 •

edited

Loading