[SourceKit] SourceKitdUID: Implement hash(into:) rather than hashValue #20868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@nkcsgexi Good catch, thanks! I filed swiftlang/swift-syntax#48 |
|
Build failed |
|
Linux failure is unrelated; rerunning smoke tests on the platform. @swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR was originally part of #20685.)
SE-0206 deprecated hashValue as a Hashable requirement. This PR updates SourceKit to migrate to the new hashing interface,
hash(into:). The change will make SourceKitUIDs hash a little faster, but otherwise, it's effectively NFC.I plan to add a compiler warning for hashValue-based Hashable conformances; this is a preemptive fix for that warning.