Skip to content

Modernize hashing #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Modernize hashing #48

merged 1 commit into from
Nov 29, 2018

Conversation

lorentey
Copy link
Member

(This is a followup to swiftlang/swift#20868.)

Change syntax nodes to implement hash(into:) instead of hashValue. The latter was deprecated as a protocol requirement in SE-0206, and implementing it may cause deprecation warnings soon. Defining hash(into:) also makes for slightly faster hashing.

Change syntax nodes to implementing hash(into:) instead of hashValue. The latter was deprecated as a protocol requirement in SE-0206.
@lorentey lorentey requested a review from nkcsgexi November 29, 2018 19:36
@lorentey
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lorentey !

@nkcsgexi nkcsgexi merged commit 9f7918e into master Nov 29, 2018
@keith keith deleted the modernize-hashing branch December 7, 2022 00:53
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Detect and delete semicolons nested in code blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants