[SR-237] Move SKIP_TEST_* arguments to Python #1396
Conversation
|
@swift-ci Please test |
|
@gribozavr Looks like a failure in protocol_resilience.sil. This was expected: And this was the actual value: I'm not sure why this would be |
|
@gribozavr Could you kick off another test for this pull request? I believe the previous CI failure was unrelated--let me know if you disagree. |
|
@swift-ci Please test OS X platform |
|
Hmm, looks like both of my pull requests, this one and #1316, are failing due to |
|
Yup, the |
|
Looks like the CI is in a good mood tonight. If someone were to ask @swift-ci to please test, I bet it would pass! 😁 |
|
@modocache Yes, master is green tonight! But seems like there are conflicts now (probably after we merged #1426). |
modocache
force-pushed
the
build-script-host-test
branch
from
2b4cc27 to
8f20f91
Compare
|
@gribozavr Thanks for the heads up. Rebased and ready to go! |
|
@swift-ci Please test |
- Migrate `SKIP_TEST_IOS`, `SKIP_TEST_TVOS`, and `SKIP_TEST_WATCHOS` to Python. - In the `build-script-impl` shellscript, only deal with `SKIP_TEST_*_HOST` and `SKIP_TEST_*_SIMULATOR` variables. - Introduce a `--host-test` flag to the Python `build-script` in order to allow users to specify whether to run host tests. These flags still don't do anything. - Fix typo: `skip-build-tvos_device` was meant to be `skip-build-tvos-device`.
modocache
force-pushed
the
build-script-host-test
branch
from
8f20f91 to
03fd72f
Compare
|
@swift-ci Please test |
[SR-237] Move SKIP_TEST_* arguments to Python
|
@gribozavr are you OK with the fact that this merge happened? It surprised me a bit as I thought I was supposed to be vetting the work. |
|
@dabrahams Since @modocache has commit privileges now, he has every right to do so. But since build-script is so complex, I'd prefer changes to it to be reviewed by someone. |
|
My bad, everyone! I had assumed that the only thing keeping this from being merged was a passing CI result, which I finally received thanks to @gribozavr triggering CI. @dabrahams, please let me know if there are other issues I can address here. I'll also try not to fewer assumptions about what has and hasn't been reviewed. Sorry again! 🙇 |
What's in this pull request?
More work on SR-237:
SKIP_TEST_IOS,SKIP_TEST_TVOS, andSKIP_TEST_WATCHOSto Python.build-script-implshellscript, only deal withSKIP_TEST_*_HOSTandSKIP_TEST_*_SIMULATORvariables.--host-testflag to the Pythonbuild-scriptin order to allow users to specify whether to run host tests. These flags still don't do anything (host tests on Darwin aren't implemented yet).skip-build-tvos_devicewas meant to beskip-build-tvos-device.Why merge this pull request?
SKIP_TEST_*variables in the shellscript--instead using the explicitSKIP_TEST_*_HOSTandSKIP_TEST_*_SIMULATORvariables. Three fewer variables in a 2,000-line shellscript is a good thing!--host-testisn't very useful for Darwin platforms yet, on Android it's possible to run tests on the host device usingadb shell. In the coming days I'd like to discuss merging the Android fork upstream, and that pull request will make use of the--host-testflag.What downsides are there to merging this pull request?
--host-testisn't immediately useful for iOS, tvOS, or watchOS. Some would argue these changes should be made alongside the commit that introduces host tests on these platforms.--host-test, one for--skip-test-*, etc. Personally I think a single pull request is less noisy, and easier for the maintainers of this project. Please let me know if you disagree!