Skip to content

[build-script] Skip option for non-Darwin stdlib tests #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

modocache
Copy link
Contributor

What's in this pull request?

It's possible to cross-compile for iOS while skipping stdlib tests on OS X:

$ utils/build-script --ios -- --skip-test-osx

The same is not possible on Linux. Add options to skip builds and tests on non-Darwin platforms: Linux, FreeBSD, and Cygwin. This makes the following possible:

$ utils/build-script --some-other-platform --skip-test-linux

Why merge this pull request?

  • This ports functionality that exists for OS X to Linux, FreeBSD, and Cygwin.
  • Although none of these platforms are currently capable of cross-compiling, the Android fork cross-compiles from Linux to Android. These options would immensely useful there, since otherwise there is no easy way to only run the tests for Android when building on Linux.

What downsides are there to merging this pull request?

  • One could argue that it should be merged alongside the Android fork. However, that would conflate that set of changes (a port of Swift to a new platform) with these (more options for the build script).

It's possible to cross-compile for iOS while skipping stdlib tests
on OS X:

```
$ utils/build-script --ios -- --skip-test-osx
```

The same is not possible on Linux. Add options to skip builds and
tests on non-Darwin platforms: Linux, FreeBSD, and Cygwin.
@gribozavr
Copy link
Contributor

@swift-ci Please smoke test

gribozavr added a commit that referenced this pull request Feb 24, 2016
…s-linux

[build-script] Skip option for non-Darwin stdlib tests
@gribozavr gribozavr merged commit 0d307d4 into swiftlang:master Feb 24, 2016
@modocache modocache deleted the build-script-skip-builds-tests-linux branch February 24, 2016 07:23
@modocache modocache mentioned this pull request Feb 25, 2016
MaxDesiatov pushed a commit that referenced this pull request Oct 19, 2020
[pull] swiftwasm from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants