Move build-script argument parser to separate module
#11880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild-script into a separate module.
This was referenced Sep 12, 2017
Merged
|
LGTM. Thank you for splitting this out! |
gottesmm
approved these changes
Sep 12, 2017
|
@swift-ci smoke test |
|
I'm going to merge this change and then move on to rebase and test #11882. |
najacque
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR simply moves the argument parsing logic from the
build-scriptmain function into a separate module. There are no functional changes here apart from wrapping up the parser instantiation into a newcreate_argument_parserfunction. Having the parser in a separate module will allow for testing and stage future changes on the path to merging #11872.rdar://problem/34336890