Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.10] Fix warnings about retroactive conformances when building swift-syntax 510 with a Swift 6 compiler #2644

Merged
merged 1 commit into from
May 7, 2024
Merged

[5.10] Fix warnings about retroactive conformances when building swift-syntax 510 with a Swift 6 compiler #2644

merged 1 commit into from
May 7, 2024

Commits on May 7, 2024

  1. Fix warnings about retroactive conformances when building swift-synta… 

    …x 510 with a Swift 6 compiler

- **Explanation**: When building swift-syntax using a Swift 6 compiler, it emits warnings about retractive conformances. Add conditional compilation conditions to add `@retroactive` where needed if compiling with a Swift 6 compiler to fix those warnings.
- **Scope**: No functionality change. Does not require a new toolchain, will just be a new swift-syntax tag
- **Risk**: Low, no functionality change.
- **Testing**: Verified that swift-syntax still builds using a Swift 5 and Swift 6 compiler
- **Issue**: rdar://127134889
- **Reviewer**:  @bnbarham
    @ahoppen
    ahoppen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d60eab9 View commit details
    Browse the repository at this point in the history