[5.10] Fix warnings about retroactive conformances when building swift-syntax 510 with a Swift 6 compiler #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x 510 with a Swift 6 compiler - **Explanation**: When building swift-syntax using a Swift 6 compiler, it emits warnings about retractive conformances. Add conditional compilation conditions to add `@retroactive` where needed if compiling with a Swift 6 compiler to fix those warnings. - **Scope**: No functionality change. Does not require a new toolchain, will just be a new swift-syntax tag - **Risk**: Low, no functionality change. - **Testing**: Verified that swift-syntax still builds using a Swift 5 and Swift 6 compiler - **Issue**: rdar://127134889 - **Reviewer**: @bnbarham
|
@swift-ci Please test |
bnbarham
approved these changes
May 7, 2024
airspeedswift
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@retroactivewhere needed if compiling with a Swift 6 compiler to fix those warnings.