Replace string-based keyword references with Keyword enum in CodeGeneration
#2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Aug 14, 2023
Comment on lines
538
to
540
| .keyword(.`private`), | ||
| .keyword(.`fileprivate`), | ||
| .keyword(.`internal`), |
There was a problem hiding this comment.
Do these even need to be backpacked here. IIRC the only case that needs to be backtracked on the call side is init.
Same in a couple more places
There was a problem hiding this comment.
Great point thank you for it! ❤️ Just pushed the corrected version.
Matejkob
force-pushed
the
remove-string-based-reference-of-keywords
branch
from
1f99046 to
57d105d
Compare
|
@swift-ci Please test |
|
Thanks for this and other code reviews @ahoppen. Sending much love! ❤️ |
|
@Matejkob Looks like there’s a merge conflict now. Could you rebase the PR? |
…ration The CodeGeneration module was previously referring to keywords using string-based references like switch, which is not idiomatic Swift. To make the code more concise and in line with Swift's best practices, this commit introduces a Keyword enum in the KeywordSpec.swift file. Now, instead of string-based references, the new Keyword enum contains all the possible keyword kinds. It also includes a computed property that returns the corresponding KeywordSpec for a given keyword, allowing for more concise and idiomatic references. The code has been refactored to replace all string-based keyword references with members of the newly introduced Keyword enum. Associated tests have also been updated to reflect these changes.
auto-merge was automatically disabled
August 15, 2023 19:05
Head branch was pushed to by a user without write access
Matejkob
force-pushed
the
remove-string-based-reference-of-keywords
branch
from
57d105d to
9c270a7
Compare
|
@ahoppen I've just resolved the merge conflict. |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #2006
Resolves #2008