Replace string-based token references with Token enum in CodeGeneration
#2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matejkob
force-pushed
the
remove-string-based-reference-of-tokens
branch
from
7971c34 to
98be350
Compare
Matejkob
commented
Aug 5, 2023
Matejkob
force-pushed
the
remove-string-based-reference-of-tokens
branch
from
98be350 to
7324a4c
Compare
ahoppen
reviewed
Aug 5, 2023
CodeGeneration/Sources/generate-swiftsyntax/templates/swiftparser/ParserTokenSpecSetFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Tests/ValidateSyntaxNodes/ValidateSyntaxNodes.swift
Outdated
Show resolved
Hide resolved
This was referenced Aug 5, 2023
Matejkob
force-pushed
the
remove-string-based-reference-of-tokens
branch
from
7324a4c to
71fd968
Compare
The CodeGeneration module was previously referring to tokens using string-based references like IdentifierToken, which is not idiomatic Swift. To make the code more concise and in line with Swift's best practices, this commit introduces a Token enum in the TokenSpec.swift file. Now, instead of string-based references, the new Token enum contains all the possible token kinds. It also includes a computed property that returns the corresponding TokenSpec for a given token, allowing for more concise and idiomatic references. The code has been refactored to replace all string-based token references with members of the newly introduced Token enum. Associated tests have also been updated to reflect these changes.
Matejkob
force-pushed
the
remove-string-based-reference-of-tokens
branch
from
71fd968 to
8ebbac7
Compare
|
@swift-ci Please test |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodeGeneration module was previously referring to tokens using string-based references like
IdentifierToken, which is not idiomatic Swift. To make the code more concise and in line with Swift's best practices, this commit introduces aTokenenum in theTokenSpec.swiftfile.Now, instead of string-based references, the new
Tokenenum contains all the possible token kinds. It also includes a computed property that returns the correspondingTokenSpecfor a given token, allowing for more concise and idiomatic references.The code has been refactored to replace all string-based token references with members of the newly introduced
Tokenenum. Associated tests have also been updated to reflect these changes.Resolves #1978