Skip to content

[6.0][Test-only] Don't use invalid module to satisfy canImport check (#7647) #7678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2024
Merged

[6.0][Test-only] Don't use invalid module to satisfy canImport check (#7647) #7678

merged 1 commit into from
Jun 18, 2024

Conversation

cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan commented Jun 18, 2024 •
edited
Loading

Explanation: This is a test-only change to allow for canImport change swiftlang/swift#74519
Scope: Test only. Update a test that relies on an invalid module as test input. Replace that with a swiftinterface.
Original PR: #7647
Test: Unit-Test
Reviewer: @tshortli

@cachemeifyoucan
[Tests] Don't use invalid module to satisfy canImport check (swiftl…
6d38637 
…ang#7647)

Stop using a fake invalid module to satisfy `canImport` check for
testing as swift compiler will start to evaluate such checks to false in
the future.

Instead, using a valid swift interfacefile to satisify the external
module import dependency.

(cherry picked from commit 3b9dd49)
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner June 18, 2024 18:01
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@MaxDesiatov MaxDesiatov added bug test suite improvements to SwiftPM test suite no functional change No user-visible functional changes included and removed bug labels Jun 18, 2024
@cachemeifyoucan cachemeifyoucan merged commit 8ebb6bf into swiftlang:release/6.0 Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees

@bnbarham bnbarham

Labels
no functional change No user-visible functional changes included test suite improvements to SwiftPM test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cachemeifyoucan @bnbarham @MaxDesiatov