[Tests] Don't use invalid module to satisfy canImport check
#7647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using a fake invalid module to satisfy `canImport` check for testing as swift compiler will start to evaluate such checks to false in the future. Instead, using a valid swift interfacefile to satisify the external module import dependency.
cachemeifyoucan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
Jun 7, 2024
cachemeifyoucan
added a commit
to cachemeifyoucan/swift-package-manager
that referenced
this pull request
Jun 18, 2024
MaxDesiatov
added
test suite
cachemeifyoucan
added a commit
that referenced
this pull request
Jun 18, 2024
#7647) (#7678) Explanation: This is a test-only change to allow for `canImport` change swiftlang/swift#74519 Scope: Test only. Update a test that relies on an invalid module as test input. Replace that with a swiftinterface. Original PR: #7647 Test: Unit-Test Reviewer: @tshortli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using a fake invalid module to satisfy
canImportcheck for testing as swift compiler will start to evaluate such checks to false in the future.Instead, using a valid swift interfacefile to satisify the external module import dependency.
Motivation:
In order for change in swiftlang/swift#74199 to land, update swiftpm tests to stop using invalid swiftmodule.