[6.0] Enable -user-module-version for 6.0
#7606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was gated on `.vNext` previously, even though it was introduced before 5.10 branched off. It feels safe to enable this in 5.10.
MaxDesiatov
added
build system
|
@swift-ci test |
bnbarham
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #7263.
Explanation:
#if canImport(LibFoo, _version: "1.2.3")is not currently supported by SwiftPM, as this feature was gated on.vNext, even though it landed before SwiftPM 5.10 branched off.Scope: Isolated to llbuild build manifests and packages that have 6.0 set as their tools version.
Risk: Low as covered with a test and gated to 6.0 tools version, so shouldn't impact existing packages.
Testing: Existing
testPackageDependencySetsUserModuleVersioncase updated to check for 6.0 version.Issue: rdar://121124842
Reviewer: @bnbarham