[main] Enable -user-module-version for 6.0
#7263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was gated on `.vNext` previously, even though it was introduced before 5.10 branched off. It feels safe to enable this in 5.10.
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
MaxDesiatov
changed the title
-user-module-version for 5.10-user-module-version for 5.10
MaxDesiatov
changed the title
-user-module-version for 5.10-user-module-version for 5.11
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
-user-module-version for 5.11-user-module-version for 6.0
MaxDesiatov
commented
Mar 4, 2024
Sources/Build/BuildDescription/SwiftTargetBuildDescription.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci test |
bnbarham
approved these changes
Apr 17, 2024
|
@swift-ci please test Windows platform |
|
@swift-ci test windows |
…xd/user-module-version
MaxDesiatov
requested review from
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test |
MaxDesiatov
added
build system
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#if canImport(LibFoo, _version: "1.2.3")is not currently supported by SwiftPM, as this feature was gated on.vNext, even though it landed before SwiftPM 5.10 branched off.Steps To Reproduce:
// swift-tools-version: 6.0and try to use#if canImport(LibFoo, _version: "1.2.3")for a dependency LibFoo.Results:
The availability check won't work because
-user-module-versionoption is not passed correctly to the build system.rdar://121124842 fixed.