[6.0] NFC: Rename ResolvedTarget to ResolvedModule
#7571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target. Renamed `ResolvedTarget` to `ResolvedModule`. Added a deprecated `typealias ResolvedTarget = ResolvedModule` to allow graceful migration for users of this type. Confusion between target triples and package targets is reduced. This has no impact on how these concepts are named in user-visible APIs like `PackageDescription` and `PackagePlugin`, target there can stay as "target" for as long as needed. Remaining internal uses of "target" outside of "target triple" context, like `*TargetBuildDescription` will be renamed in future PRs. (cherry picked from commit 27996b8)
|
@swift-ci please test |
bnbarham
approved these changes
May 16, 2024
|
@swift-ci please clean test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target.
Renamed
ResolvedTargettoResolvedModule. Added a deprecatedtypealias ResolvedTarget = ResolvedModuleto allow graceful migration for users of this type.Confusion between target triples and package targets is reduced.
This has no impact on how these concepts are named in user-visible APIs like
PackageDescriptionandPackagePlugin, target there can stay as "target" for as long as needed.Remaining internal uses of "target" outside of "target triple" context, like
*TargetBuildDescriptionwill be renamed in future PRs.Scope: NFC change
Main Branch PRs: Rename
ResolvedTargettoResolvedModule#7459Risk: Very Low
Reviewed By: @bnbarham
Testing: No new tests are necessary
(cherry picked from commit 27996b8)